Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maciekbanas/81/prepare mocks for testing vectordatabase #83

Merged

Conversation

maciekbanas
Copy link
Member

This is first approach to mocking Pinecone for tests.

Basically I mocked the real httr2::req_perform with httr2::response_json with implied parsed json body. Used for this separate R6 class, as a subclass of Pinecone.

@maciekbanas maciekbanas self-assigned this Dec 27, 2024
@maciekbanas maciekbanas linked an issue Dec 27, 2024 that may be closed by this pull request
Copy link
Member

@krystian8207 krystian8207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maciekbanas maciekbanas merged commit ef68b52 into main Dec 30, 2024
6 checks passed
@maciekbanas maciekbanas deleted the maciekbanas/81/prepare-mocks-for-testing-vectordatabase branch December 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare mocks for testing VectorDatabase
2 participants